Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID migration changes #400

Merged
merged 10 commits into from
Dec 7, 2023
Merged

ID migration changes #400

merged 10 commits into from
Dec 7, 2023

Conversation

bobbyiliev
Copy link
Contributor

@bobbyiliev bobbyiliev commented Dec 6, 2023 •
edited
Loading

As per #399 adding the ID migration schema changes.

@bobbyiliev bobbyiliev marked this pull request as ready for review December 6, 2023 19:05
@bobbyiliev bobbyiliev requested a review from dehume as a code owner December 6, 2023 19:05
@bobbyiliev bobbyiliev requested a review from benesch December 6, 2023 19:08
@benesch benesch removed their request for review December 6, 2023 19:15
@benesch
Copy link
Contributor

benesch commented Dec 6, 2023

Impressively fast turnaround, @bobbyiliev! I won't have time to meaningfully review, so deferring review to @dehume, but looked plausible on a very quick skim.

@dehume dehume mentioned this pull request Dec 7, 2023
Merged
dehume
dehume reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@dehume dehume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (two minor documentation tweaks). After we confirm whether we are using the StateUpgraders, should be good to go

examples/resources/materialize_schema/import.sh Outdated Show resolved Hide resolved
examples/resources/materialize_type/import.sh Outdated Show resolved Hide resolved
@bobbyiliev bobbyiliev requested a review from dehume December 7, 2023 18:50
@bobbyiliev bobbyiliev merged commit e6d311f into main Dec 7, 2023
6 checks passed
@bobbyiliev bobbyiliev deleted the ids-migration-connections branch December 28, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dehume dehume dehume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobbyiliev @benesch @dehume